Ping sensor, fixes #72#539
Draft
ewired wants to merge 1 commit into
Draft
Conversation
Author
|
After many weeks of usage I found out that clicking to open the menu was causing it to report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thoroughly tested ping sensor based on a
pingsubprocess. If your update interval is set to 3 seconds and a ping doesn't respond by the next interval, it will display3000+ msand end the subprocess early, otherwise falling back to the max ping timeout of 5 seconds which will display5000+ ms. Upon error (no DNS resolution, invalid host, etc) it displays?? ms. I wanted to make sure the user gets a chance to fully type the intended host before confirming, so the prefs may be a bit unique compared to other features. It is lacking a unique icon for the original icon set, I just copied the cloud icon. Tested on NixOS.